feat(AutoSign): Add AutoSign Module#236
Open
IceTank wants to merge 2 commits intolambda-client:1.21.11from
Open
feat(AutoSign): Add AutoSign Module#236IceTank wants to merge 2 commits intolambda-client:1.21.11from
IceTank wants to merge 2 commits intolambda-client:1.21.11from
Conversation
…lose ópened signs
emyfops
reviewed
Feb 3, 2026
beanbag44
requested changes
Feb 22, 2026
Member
beanbag44
left a comment
beanbag44
left a comment
There was a problem hiding this comment.
looks good, couple changes though
| transitive-accessible field net/minecraft/client/gui/screen/ingame/HandledScreen focusedSlot Lnet/minecraft/screen/slot/Slot; | ||
| transitive-accessible field net/minecraft/registry/SimpleRegistry frozen Z | ||
|
|
||
| transitive-accessible field net/minecraft/client/gui/screen/ingame/AbstractSignEditScreen messages [Ljava/lang/String; |
Member
There was a problem hiding this comment.
prob just remove the white space above to move it into the # Other group
| else SignEditScreen(event.sign, true, mc.shouldFilterText()) | ||
| for (i in 0 until 4) editor.messages[i] = lines[i] | ||
| if (autoClose) { | ||
| if (writeOnFront) mc.networkHandler?.sendPacket(UpdateSignC2SPacket(event.sign.pos, true, editor.messages[0], editor.messages[1], editor.messages[2], editor.messages[3])) |
Member
There was a problem hiding this comment.
SafeContext contains connection which should be used instead of mc.networkHandler. Also 2b2t doesnt allow sign editing so this doesnt seem to work. Would it be possible to close the sign automatically without using edit sign?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AutoSign Module to autofill sign texts and auto close ópened signs